Changes to Attestation Delegation Logic

[MaxBiCC]

Hi,

I am currently using the latest commit from November 19, 2024, and have observed a change in the behavior of attestation case delegation.

Previously, as of the October 8, 2024, commit, I was able to delegate individual attestation cases via the Pending Attestations view by using the Action button located next to Approve and Deny. However, this functionality no longer appears to be working in the latest version.

I noticed in the latest GitHub updates that changes were made to files such as attestation-case.ts and attestation-cases-service.ts, where the isChiefApproval variable was removed and replaced with the newly introduced isUserEscalationApprover variable.

I suspect that the canDelegateDecision method in attestation-case.ts is responsible for this altered behavior.

There are significantly more instances of isUserEscalationApprover being used in attestation-case.ts.

While I am not categorizing this as a bug at this point, I am currently unable to fully understand the reasoning behind the changed behavior. This functionality is highly valued and frequently utilized in our environment, making it essential for it to function correctly. Using the att module and files from the October commit restores the ability to delegate attestation cases.

Hint: We are using a custom approval workflow based on a standard approval procedure (CM - Manager of attested identity), which allows the manager of an identity to decide about attestations.

[Mathnstein]

Hi @MaxBiCC - yes this was a change I had made. There seems to be some confusion on what exact functionality we want here - but the reason for the change was the UI toggle (isChiefApproval) was preventing the ability to delegate (and other actions) from the chief approval table (i.e once you had it enabled, all other actions would fail these logic checks)

Stay tuned - We're working on it.