"Cancel reservation" button is shown even though inquiry is not answered yet

[asattler]

Internal Issue created: 474724

I've found an inconsistency in the logic during approvals.
If you raise an inquiry for a request (I've not checked if it also applies to attestioncases, but might be), the UI allows the approver who send the inquiry to recall the inquiry.
But at the same time it provides you the possibility to cancel the reservation.
This lead to confusion on endusers, that's why I was asked to have a deeper look.

In the WebDesigner web this logic was different and based on my analysis the implementation in the angular portal is wrong.

imweb/projects/qer/src/lib/itshopapprove/approval.ts
public canResetReservation(isChiefApprover: boolean): boolean { return this.IsReserved.value && (this.hasAskedLastQuestion || isChiefApprover); }
The function is lacking to check if the asked question is answered, which was done in WebDesigner-WebPortal to avoid this situation.

Regards,
Andreas

[Mathnstein]

I'll have someone take a closer look at this @asattler - thanks!