Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send_onesignal_notification checkbox does not correctly display when onesignal_send_notification set to false #113

Open
kitwestneat opened this issue Mar 7, 2018 · 0 comments

Comments

@kitwestneat
Copy link

kitwestneat commented Mar 7, 2018

Description:
The send_onesignal_notification checkbox is always checked on the edit post page if the global send notification is enable and the post page is enabled.

Steps to Reproduce Issue:

  1. ensure global notification_on_post config is set true
  2. create a new post
  3. uncheck send_onesignal_notification checkbox
  4. click save draft
  5. observe checkbox is re-checked

Anything else:
It seems that get_post_meta returns '' for both false and null, making it impossible to tell if the user has explicitly set onesignal_send_notification to false. Does it make sense to change the meta valuse to 0 and 1 or something like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants