Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Subscribe" widget should also recognize subscription status #217

Open
davisshaver opened this issue Nov 19, 2019 · 5 comments
Open

"Subscribe" widget should also recognize subscription status #217

davisshaver opened this issue Nov 19, 2019 · 5 comments

Comments

@davisshaver
Copy link

davisshaver commented Nov 19, 2019

Description:
Using the "OneSignal" widget to place subscription link. Should text change or widget should be hidden if user is already subscribed?

Steps to Reproduce Issue:

  • Place the "OneSignal" widget on the site
  • Subscribe to notifications using the widget
  • Reload page
  • Click link again - no action triggered, no indication that user is already subscribed

Anything else:

@davisshaver
Copy link
Author

@rgomezp Could you let me know your thoughts on this? Would it be something the core team is interested in prioritizing? If not, would you accept a pull request?

@rgomezp
Copy link
Contributor

rgomezp commented Dec 9, 2019

@davisshaver ,
I'm sorry. I don't understand the question. What is the issue? If you would like to try the upcoming version of the plugin, you can download it here.

@davisshaver
Copy link
Author

@rgomezp The widget is a static text link. According to the docs linked above, "We highly recommend only showing this custom Prompt and link if the user is unsubscribed." The pull request in draft here is a work-in-progress to do this: #220

Maybe someone on team could help review?

@rgomezp
Copy link
Contributor

rgomezp commented Jan 28, 2020

@davisshaver ,
Thank you for your contributions. We will take a look for the next version of the plugin

@amanijoseph87
Copy link

Is this already implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants