Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: update node-fetch to 3.x #83

Open
1 task done
jpike88 opened this issue May 9, 2024 · 2 comments · May be fixed by #102
Open
1 task done

[Bug]: update node-fetch to 3.x #83

jpike88 opened this issue May 9, 2024 · 2 comments · May be fixed by #102
Labels
enhancement New feature or request

Comments

@jpike88
Copy link

jpike88 commented May 9, 2024

What's on your mind?

Am getting this warning now:

(node:59969) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

This is a problem with node-fetch 2.x, not 3.x. Please update the dependency and release a new version

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nan-li
Copy link
Contributor

nan-li commented May 9, 2024

Hi @jpike88 thank you for reporting, we will look into updating the dependency.

Despite the warning, are you able to use this package?

@nan-li nan-li added the enhancement New feature or request label May 9, 2024
@jpike88
Copy link
Author

jpike88 commented May 9, 2024

yes its just an annoying warning, not more than that

@CHC383 CHC383 linked a pull request Jan 24, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove dependence node-fetch CHC383/onesignal-node-api
2 participants
@nan-li @jpike88