Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test export_workspace + asset_per_band combination #905

Closed
JeroenVerstraelen opened this issue Oct 15, 2024 · 8 comments · Fixed by #916
Closed

test export_workspace + asset_per_band combination #905

JeroenVerstraelen opened this issue Oct 15, 2024 · 8 comments · Fixed by #916
Assignees

Comments

@JeroenVerstraelen
Copy link
Contributor

Edit batch job options from existing integrationtest

@JeroenVerstraelen JeroenVerstraelen self-assigned this Oct 15, 2024
@VictorVerhaert
Copy link

example job that should be able to work: j-241011225b584a8ca14e374da7a9afe4

@JeroenVerstraelen
Copy link
Contributor Author

In cdse integrationtests, @EmileSonneveld is working on asset_per_band.

@soxofaan
Copy link
Member

Edit batch job options from existing integrationtest

@JeroenVerstraelen which existing integration test? I can't find any export_workspace or asset_per_band related test in neither:

@VictorVerhaert
Copy link

For this issue we will probably have to create a bucket for integration tests to avoid using (and leaking) workspace names of project specific buckets

@EmileSonneveld
Copy link
Contributor

This integration test would be in a private repo, so not risk of leaking workspace names

EmileSonneveld added a commit that referenced this issue Oct 22, 2024
@soxofaan
Copy link
Member

can't we have the test logic public, but we manage the secrets in the Vault? We already have plenty of tests that work that way

@JeroenVerstraelen
Copy link
Contributor Author

Requires a bucket for integration tests and a workspace.
Alternative: moto library has throwaway s3 test service (scala requires swift url, you'll have to point this to the boto3 service via env variable).

@EmileSonneveld EmileSonneveld linked a pull request Oct 23, 2024 that will close this issue
@soxofaan
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants