iterate over asset_ids instead of asset index in GFMapJobManager.on_j… #186
+13
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@VictorVerhaert, this is a blocking issue for the WorldCereal extractions. To summarize:
GFMapJobManager.on_job_done
we looped over the asset index in the batch job metadata when downloading multiple assets from one job (which can be the case ifsample_by_feature=True
)I don't believe this is 100% backwards compatible as now the
output_path_gen
callable requiresasset_id
as a keyword argument. However, in light of the future deprecation of theGFMapJobManager
and the fact that I don't see any other solution within the current API, I think this is justifiable.In case you have another suggestion, please let me know!
closes #185