Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output labels should on FeatureComputers be generated dynamically & improve the import strategy #44

Closed
2 tasks done
GriffinBabe opened this issue Feb 7, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@GriffinBabe
Copy link
Collaborator

GriffinBabe commented Feb 7, 2024

There are a few things to rework for the feature extractors. First, the base UDF imports should be handled using meta-programming, and not being hardcoded in the feature_extractors.py file, as it will inevitably causes conflicts later.

Our very first user also points that the output_labels function should be more dynamic. In his example, he wants to implement a custom Vegetation Index Calculator that requires user parameters and that will ultimately influence the output labels, which need to be set up statically in the processing graph after the UDF. One idea of implementing this would be to be able to optionally pass the user parameters directly in the output_labels parameters, so that it can access this information when running locally on GFMAP

  • Make imports dynamic using meta-programming
  • Allow the output_labels to be dynamic and depend on user parameters when running locally
@GriffinBabe GriffinBabe added the enhancement New feature or request label Feb 7, 2024
@GriffinBabe GriffinBabe self-assigned this Feb 7, 2024
@GriffinBabe GriffinBabe changed the title Output labels should be generated dynamically Output labels should on FeatureComputers be generated dynamically & improve the import strategy Feb 7, 2024
@GriffinBabe
Copy link
Collaborator Author

Closed by #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant