-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run_udf: Unclear why two data types are defined #515
Comments
Git blame shows that this was changed 2021 (6ec1848) from two schemas (raster-cube and array) to two schemas (array and any). I believe this was done to encourage usage in datacube operations such as reduce_dimension and apply_dimension. It's not made overly clear in the description of the parameter. Either we need to describe the two schemas better or we should remove it and explain better what users are expected to do. |
you mean from three schemas (raster-cube, array and any) to two schemas (array and any) regardless, I have no idea why it's like this or if there are important reasons not to simplify as proposed. |
Yes, I agree... I guess it was meant as a way to somehow recommend that UDFs are used in callbacks. |
Process ID: run_udf
Describe the issue:
Run UDF has the following definition for
data
:Why does it explicitly define an array type? The way the second schema is defined, both apply for an array. So it's equivalent to:
Can someone remember why this is the way it is? @soxofaan maybe?
Proposed solution:
Simplify the schema?
The text was updated successfully, but these errors were encountered: