-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for openeo API v1.2 and openeo-processes v2.0.0 #195
Comments
related to Open-EO/openeo-python-client#424 in python client |
refs/sub-issues |
also support custom spec in `add_simple_function`
Something to consider from openeo-processes 2.0 :
Inconsistent usage of FYI, at the moment, openeo.vito.be/openeo/1.1/processes uses openeo-python-driver/openeo_driver/ProcessGraphDeserializer.py Lines 1584 to 1585 in 301e344
|
working on in a feature branch to provide the 2.0 version of processes at a https://openeo.vito.be/openeo/1.2/ while keeping the 1.x version on https://openeo.vito.be/openeo/1.1 and lower I think it would be good if we could also make that link more explicit in the metadata -> Open-EO/openeo-api#517 |
…uests also #229 add apply_polygon (but keep deprecated chunk_polygon)
merged current work in ec902ac: /openeo/1.2 (still flagged as not production ready for now) will expose v2 of processes |
still to do under this ticket:
|
@soxofaan our 1.2 version of the api is still marked as not production ready. Are there actually things in the implementation that make it less stable than 1.1? Or do we lack things that are required in 1.2? |
I don't think it's less stable, code-path-wise it's largely the same as 1.1 It's just not fully 1.2 compatible. We just added 1.2 feature in ad-hoc style to support use cases, we didn't do a full sweep yet to check against the full 1.2 requirements list |
Looking at the changelog, I would say we can simply mark it as production ready. To me it seems to be the best version we have to offer, with some very relevant 1.2 specific features such as log level.
…________________________________
From: Stefaan Lippens ***@***.***>
Sent: Tuesday, November 7, 2023 9:56 AM
To: Open-EO/openeo-python-driver ***@***.***>
Cc: Jeroen Dries ***@***.***>; Comment ***@***.***>
Subject: Re: [Open-EO/openeo-python-driver] Updates for openeo API v1.2 and openeo-processes v2.0.0 (Issue #195)
I don't think it's less stable, code-path-wise it's largely the same as 1.1
It's just not fully 1.2 compatible. We just added 1.2 feature in ad-hoc style to support use cases, we didn't do a full sweep yet to check against the full 1.2 requirements list
—
Reply to this email directly, view it on GitHub<#195 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABNJPSEALNYJRAYHWG2AUMTYDHZUBAVCNFSM6AAAAAAYFBFAKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJYGA3DSNJRHA>.
You are receiving this because you commented.Message ID: ***@***.***>
VITO Disclaimer: http://www.vito.be/e-maildisclaimer
|
I just remembered something that could be a bit tricky:
This means that if we bump 1.2. to be production ready, users of the generic "openeo.vito.be" connection url, will suddenly be bumped to v2 version of processes (served at In general I don't think this will cause issues. |
flagged 1.2 as production ready with 97d5192 |
flagging 1.2 as production ready caused nextland integration tests to fail because these use chunk_polygon which does not exist in v2 version of processes. will revert flagging 1.2 as production ready for now. And then port nextland to apply_polygon |
pushed another attempt to flag 1.2 as production ready: 9f5361c |
Upcoming API/spec updates:
This is central/epic ticket to follow up necessary coverage of these changes in the python client
The text was updated successfully, but these errors were encountered: