Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] feat: support apt install package #269

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

myml
Copy link
Collaborator

@myml myml commented Mar 11, 2024

支持在玲珑中使用apt安装软件包

Log:

支持在玲珑中使用apt安装软件包

Log:
@deepin-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myml
Once this PR has been reviewed and has the lgtm label, please assign zccrs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myml myml marked this pull request as draft March 11, 2024 11:29
@myml myml changed the title feat: support apt install package [Draft] feat: support apt install package Mar 11, 2024
@deepin-bot
Copy link

deepin-bot bot commented May 13, 2024

TAG Bot

New tag: 1.5.0-1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #372

@deepin-bot
Copy link

deepin-bot bot commented May 14, 2024

TAG Bot

New tag: 1.5.1-1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #421

@deepin-ci-robot
Copy link
Collaborator

deepin pr auto review

关键摘要:

  • main.cpp中使用fork()创建子进程可能会导致未处理的错误和资源管理问题。
  • LinglongBuilder::buildStageRunContainer方法中,使用std::vector<std::string>来存储 capabilities 可能会导致不必要的内存分配和复制。
  • LinglongBuilder::buildStageRootfs方法中,将根文件系统的只读属性设置为false可能会导致安全问题,需要评估是否有必要。
  • LinglongBuilder::writeFile方法中,直接使用QFileQIODevice可能会导致资源泄露,应该使用QFiledDevice来管理文件对象。
  • LinglongBuilder::buildStageRootfs方法中,使用sleep(3)可能会导致不必要的延迟,应该评估是否有必要。
  • LinglongBuilder::buildStageRunContainer方法中,使用linglong::utils::command::Exec执行newuidmapnewgidmap可能会导致安全问题,需要评估这些命令的执行是否安全。
  • LinglongBuilder::buildStageCommitBuildOutput方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageSource方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageIDMapping方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageRootfs方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageRunContainer方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageCommitBuildOutput方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageSource方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageIDMapping方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageRootfs方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageRunContainer方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageCommitBuildOutput方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageSource方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageIDMapping方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageRootfs方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageRunContainer方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageCommitBuildOutput方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageSource方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageIDMapping方法中,使用linglong::utils::error::Result<void>来处理错误可能会导致错误处理不完整。
  • LinglongBuilder::buildStageRootfs

@deepin-bot
Copy link

deepin-bot bot commented Jun 25, 2024

TAG Bot

New tag: 1.5.6-1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants