Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update cmake version as upcoming deprecation #184

Open
chryswoods opened this issue Mar 31, 2024 · 2 comments
Open

[BUG] Update cmake version as upcoming deprecation #184

chryswoods opened this issue Mar 31, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@chryswoods
Copy link
Contributor

We currently set cmake_minimum_required to 3.3.0. CMake support for <3.5 is deprecated and will soon be dropped. We should update to a newer version for 2024.2.0.

As part of this, it may also be worth reviewing some of our pins. For example, the packaging pin caused issue with boa and is being removed in 2024.1.0. Also, there is a pin for compiler 12.3.0 on Linux. We should check if the issues we saw for newer gcc have been resolved.

Also, python 3.12 support looks like it is almost there for all our dependencies. We should see if we can move to 3.10, 3.11, 3.12 for 2024.2.0.

Additional context
I've added this issue to remind myself to explore this as part of the next major version.

@chryswoods chryswoods added the bug Something isn't working label Mar 31, 2024
@chryswoods chryswoods added this to the 2024.2.0 milestone Mar 31, 2024
@lohedges
Copy link
Contributor

Yes, that's a good idea. I believe the gcc pin was for RDKit. It's probably worth asking Exs if we can unpin or update the RDKit version as it's quite old now. I don't think RDKit was the issue as of itself, rather the environment resolution or a dependency that was pulled in.

@lohedges
Copy link
Contributor

It actually looks like we only set a minimum version. Perhaps they retained the pin for their internal build so this is hopefully no longer needed.

@chryswoods chryswoods modified the milestones: 2024.2.0, 2024.3.0 Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants