Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Sire::Mol::Frame::toByteArray initialises QByteArray incorrectly #249

Closed
lohedges opened this issue Oct 28, 2024 · 0 comments · Fixed by #250
Closed

[BUG] Sire::Mol::Frame::toByteArray initialises QByteArray incorrectly #249

lohedges opened this issue Oct 28, 2024 · 0 comments · Fixed by #250
Assignees
@lohedges
Labels
bug Something isn't working

Comments

@lohedges
Copy link
Contributor

As discussed here the QByterArray for used to serialise the trajectory frame is instantiated incorrectly, which causes a segmentation fault when the system size (and nbytes) is large. The function also incorrectly uses the .count() method to determine the number of bytes for QByteArray objects. This is used to count the occurrences of a specific byte. Instead, the .size() method should be used to return the number of bytes.
@lohedges lohedges added the bug Something isn't working label Oct 28, 2024
@lohedges lohedges self-assigned this Oct 28, 2024
lohedges added a commit that referenced this issue Oct 28, 2024
@lohedges
Fix instantiation of QByteArray and counting of bytes. [closes #249]
926f082
@lohedges lohedges mentioned this issue Oct 28, 2024
Merged
lohedges added a commit that referenced this issue Oct 29, 2024
@lohedges
Merge pull request #250 from OpenBioSim/fix_249
146632e 
Fix issue #249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lohedges lohedges

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #249 OpenBioSim/sire
1 participant
@lohedges