Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adjustment of adc ranges without providing delay ranges #521

Open
rettigl opened this issue Nov 18, 2024 · 2 comments · May be fixed by #525
Open

Allow adjustment of adc ranges without providing delay ranges #521

rettigl opened this issue Nov 18, 2024 · 2 comments · May be fixed by #525
Assignees
@rettigl

Comments

@rettigl
Copy link
Member

rettigl commented Nov 18, 2024

Currently, you have to provide delay_ranges to delay_calibration if you provide adc_ranges. This should be changed such that delay ranges are picked from a file if possible.
@rettigl rettigl self-assigned this Nov 18, 2024
@rettigl
Copy link
Member Author

rettigl commented Nov 22, 2024

Specifically, it does work for the 1st execution, but not for the 2nd one, because then a calibration dict is already present.

@rettigl rettigl linked a pull request Nov 22, 2024 that will close this issue
Open
@rettigl
Copy link
Member Author

rettigl commented Nov 22, 2024

The underlying issue is that it is not well defined what to do if calibration parameters are already present. Should just these be used, or the new ones be read from the file of e.g. a different scan. To solve this, a new option has been added in PR #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rettigl rettigl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delay calibration fixes OpenCOMPES/sed
1 participant
@rettigl