Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging tests and fixes #560

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Logging tests and fixes #560

wants to merge 3 commits into from

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Feb 7, 2025

Closes #558 and adds logger tests

@coveralls
Copy link
Collaborator

coveralls commented Feb 7, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13229911609

Details

  • 99 of 99 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 92.269%
Totals Coverage Status
Change from base Build 13167417292: 0.1%
Covered Lines: 7793
Relevant Lines: 8446
💛 - Coveralls

@rettigl rettigl requested a review from zain-sohail February 7, 2025 21:11
zain-sohail
zain-sohail approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Seems like there's no clear way to save default parameters from a function (even when no args are passed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zain-sohail zain-sohail zain-sohail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sed cannot be imported if current directory read-only
3 participants
@rettigl @coveralls @zain-sohail