Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using curvature instead of normal in the code #9

Open
leochien1110 opened this issue Aug 22, 2023 · 1 comment
Open

Using curvature instead of normal in the code #9

leochien1110 opened this issue Aug 22, 2023 · 1 comment

Comments

@leochien1110
Copy link

Hi, I appreciate all this effort in developing this awesome calibration tool. I have a question about the normal you adopt in the source code.

After diving into the code, I notice that you commented out the original normal properties and calculations and replaced them with curvature.

Is there any reason for this shift such as performance or accuracy?

Thank you in advance.

@sisyphus-99
Copy link
Collaborator

Hello, thanks for your careful reading.
We originally changed the normal vector to curvature mainly for time reasons. Computing the similarity of normal vectors uses large-scale matrix multiplications, which is very time-consuming. However, since the information contained in curvature is not as rich as the normal vector, we changed it to a normal vector again in the new version. The code repository is updated now. Considering efficiency, we added downsampling to the point cloud and only use the margin of the large-area mask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants