Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Tool: atoms have to be reselected to realign to different axis #1665

Closed
matterhorn103 opened this issue Apr 18, 2024 · 2 comments · Fixed by #1925
Closed

Align Tool: atoms have to be reselected to realign to different axis #1665

matterhorn103 opened this issue Apr 18, 2024 · 2 comments · Fixed by #1925

Comments

@matterhorn103
Copy link
Contributor

This is with the current nightly AppImage, haven't tested with other versions yet.

Avogadro version: (please complete the following information from the About box):

  • Avogadrolibs: 1.99.0
  • Qt: 5.15.2

Desktop version: (please complete the following information):

  • OS: openSUSE Tumbleweed with KDE Plasma 6.0.3
  • Version 20240416

Describe the bug
To align a bond (or any two atoms even if not bonded) to one of the principal axes, you can select the chosen axis from the drop-down, and select two atoms in the view. Those two steps can be done in either order.

After then clicking Align, the molecules in the view are realigned appropriately. The two atoms that were selected remain selected and labelled with #1 and #2. However, changing the axis and then clicking align again doesn't result in a second realignment – the two atoms must be reselected.

To Reproduce
Steps to reproduce the behavior:

  1. Draw a molecule
  2. Select the Align Tool
  3. Select two atoms
  4. Click align (to e.g. the x-axis by default)
  5. Observe successful realignment
  6. Change alignment axis to e.g. z
  7. Click align
  8. Observe no change!
  9. Reselect the same two atoms
  10. Click align
  11. Observe that the alignment is now successful

Expected behavior
Clicking Align should always result in realignment based on the current selection, without reselection being required.

Alternatively, all atoms should be automatically deselected after an alignment is carried out.

Both would match user expectations. The latter is less good though, as it would be convenient to be able to quickly compare the alignment to several different axes. Especially since the axes are unlabelled, meaning the user might not align to the correct axis on the first attempt.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Here are the build results
Avogadro2.AppImage
Ubuntu-Latest.tar.gz
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Here are the build results
Avogadro2.AppImage
Ubuntu-Latest.tar.gz
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

matterhorn103 pushed a commit to matterhorn103/avogadrolibs that referenced this issue Jan 13, 2025
peach280 pushed a commit to peach280/avogadrolibs that referenced this issue Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant