From 41592c9ad2b6659b763c8c9d8989608deaf7057f Mon Sep 17 00:00:00 2001 From: Okke Harsta Date: Mon, 27 Jan 2025 15:32:57 +0100 Subject: [PATCH] Localized ServiceDesk in new I18n --- account-gui/src/locale/I18n.js | 12 ++-- account-gui/src/locale/en.js | 13 +--- account-gui/src/locale/js/en/strings.json | 16 +++-- account-gui/src/locale/js/nl/strings.json | 12 +++- account-gui/src/locale/nl.js | 13 +--- account-gui/src/verify/ServiceDesk.svelte | 16 ++--- myconext-gui/src/locale/I18n.js | 8 +-- myconext-gui/src/locale/en.js | 41 ------------- myconext-gui/src/locale/js/en/strings.json | 39 +++++++++++- myconext-gui/src/locale/js/nl/strings.json | 41 ++++++++++++- myconext-gui/src/locale/nl.js | 43 +------------ myconext-gui/src/routes/PersonalInfo.svelte | 6 +- myconext-gui/src/utils/services.js | 56 ++++++++--------- myconext-gui/src/verify/ServiceDesk.svelte | 68 ++++++++++----------- 14 files changed, 181 insertions(+), 203 deletions(-) diff --git a/account-gui/src/locale/I18n.js b/account-gui/src/locale/I18n.js index 2f078ca7..0cb7faa2 100644 --- a/account-gui/src/locale/I18n.js +++ b/account-gui/src/locale/I18n.js @@ -12,12 +12,7 @@ const format = (msg, ...args) => { let result = msg; for (let i = 0; i < args.length; i++) { const pos = i + 1; - if (typeof args[i] === "string") { - result = result.replace("%" + pos + "$s", args[i]); - } - if (typeof args[i] === "number") { - result = result.replace("%" + pos + "$d", args[i]); - } + result = result.replace("%" + pos + "$s", args[i]); } return result; }; @@ -25,7 +20,10 @@ const format = (msg, ...args) => { let locale = "en" const I18n = { - changeLocale: lang => locale = lang, + changeLocale: lang => { + locale = lang; + I18nLocal.locale = lang; + }, currentLocale: () => locale, t: (key, model = {}, fallback = null) => { const msg = translations[locale][key] diff --git a/account-gui/src/locale/en.js b/account-gui/src/locale/en.js index edc42cc0..3b9e4eaa 100644 --- a/account-gui/src/locale/en.js +++ b/account-gui/src/locale/en.js @@ -423,18 +423,9 @@ const en = { issuers: { eherkenning: "eIDAS", idin: "Idin", - studielink: "Studielink" + studielink: "Studielink", + servicedesk: "Service Desk" } - }, - serviceDesk: { - confirmIdentityHeader: "You need to manually confirm your identity", - confirmIdentity: "You must confirm your identity at one of our eduID Service Desks.", - stepsHeader: "Follow these steps:", - step1: "Enter your full name as it appears on your ID (first and last name).", - step2: "Generate a personal verification code.", - step3: "Present your code and ID to an eduID Service Desk. They will verify your identity manually.", - redirectWarning: "We will redirect you to another website to enter your name. You won’t be able to log in to {{service}} immediately afterward; you will first need to contact a eduID Service Desk.", - next: "Open website to enter your name" } }; export default en; diff --git a/account-gui/src/locale/js/en/strings.json b/account-gui/src/locale/js/en/strings.json index 02cfee73..523f1b8f 100644 --- a/account-gui/src/locale/js/en/strings.json +++ b/account-gui/src/locale/js/en/strings.json @@ -1,5 +1,4 @@ { - "About.Info.COPY": "App information", "Sidebar.Home.COPY": "Home", "Sidebar.PersonalInfo.COPY": "Personal info", @@ -580,7 +579,7 @@ "MagicLink.OpenMailTitle.COPY": "Open your e-mail", "MagicLink.OpenMailDisclaimer.COPY": "Can't find the email? Check the spam folder", "MagicLink.Header.COPY": "Check your email", - "MagicLink.Info.COPY": "Press the link we sent to %1$s.", + "MagicLink.Info.COPY": "Press the link we sent to ", "MagicLink.Awaiting.COPY": "Waiting for you to press the link…", "MagicLink.OpenGMail.COPY": "Open gmail.com", "MagicLink.OpenOutlook.COPY": "Open outlook.com", @@ -823,5 +822,14 @@ "ExternalAccountLinkingError.Subtitle.COPY": "We’re sorry, we were unable to retrieve the requested information.", "ExternalAccountLinkingError.TryAnotherOption.COPY": "Please try another method", "ReferenceNames.Idin.COPY": "iDIN", - "ReferenceNames.Eherkenning.COPY": "eIDAS" -} + "ReferenceNames.Eherkenning.COPY": "eIDAS", + "ServiceDesk.ConfirmIdentityHeader.COPY": "You need to manually confirm your identity", + "ServiceDesk.ConfirmIdentity.COPY": "You must confirm your identity at one of our eduID Service Desks.", + "ServiceDesk.StepsHeader.COPY": "Follow these steps:", + "ServiceDesk.Step1.COPY": "Enter your full name as it appears on your ID (first and last name).", + "ServiceDesk.Step2.COPY": "Generate a personal verification code.", + "ServiceDesk.Step3.COPY": "Present your code and ID to an eduID Service Desk. They will verify your identity manually.", + "ServiceDesk.RedirectWarning.COPY": "We will redirect you to another website to enter your name. You won’t be able to log in to %1$s immediately afterward; you will first need to contact a eduID Service Desk.", + "ServiceDesk.Next.COPY": "Open website to enter your name" + +} \ No newline at end of file diff --git a/account-gui/src/locale/js/nl/strings.json b/account-gui/src/locale/js/nl/strings.json index 63f1968b..24c2afb5 100644 --- a/account-gui/src/locale/js/nl/strings.json +++ b/account-gui/src/locale/js/nl/strings.json @@ -580,7 +580,7 @@ "MagicLink.OpenMailTitle.COPY": "Open je e-mail", "MagicLink.OpenMailDisclaimer.COPY": "Kun je de mail niet vinden? Kijk ook in de spam folder", "MagicLink.Header.COPY": "Controleer je e-mail", - "MagicLink.Info.COPY": "Druk op de link die we verstuurd hebben naar %1$s.", + "MagicLink.Info.COPY": "Druk op de link die we verstuurd hebben naar ", "MagicLink.Awaiting.COPY": "Wachten tot je op de link drukt…", "MagicLink.OpenGMail.COPY": "Open gmail.com", "MagicLink.OpenOutlook.COPY": "Open outlook.com", @@ -823,5 +823,13 @@ "ExternalAccountLinkingError.Subtitle.COPY": "Helaas konden we de gevraagde gegevens niet ophalen.", "ExternalAccountLinkingError.TryAnotherOption.COPY": "Probeer een andere manier", "ReferenceNames.Idin.COPY": "iDIN", - "ReferenceNames.Eherkenning.COPY": "eIDAS" + "ReferenceNames.Eherkenning.COPY": "eIDAS", + "ServiceDesk.ConfirmIdentityHeader.COPY": "Bevestig wie je bent met je identiteitsbewijs", + "ServiceDesk.ConfirmIdentity.COPY": "Je kunt je identiteit ook bevestigen via een van onze eduID Service Desks.", + "ServiceDesk.StepsHeader.COPY": "Volg deze stappen:", + "ServiceDesk.Step1.COPY": "Vul je volledige naam in zoals die op je identiteitsbewijs staat (voornamen en achternaam).", + "ServiceDesk.Step2.COPY": "Genereer een persoonlijke controlecode.", + "ServiceDesk.Step3.COPY": "Laat je controlecode en identiteitsbewijs zien aan een eduID Service Desk. Die bevestigt zo je identiteit.", + "ServiceDesk.RedirectWarning.COPY": "We sturen je door naar een andere website om je naam in te vullen. Je kunt daarna nog niet gelijk inloggen bij %1$s, maar je moet eerst contact opnemen met een eduID Service Desk.", + "ServiceDesk.Next.COPY": "Naar gegevens invullen" } diff --git a/account-gui/src/locale/nl.js b/account-gui/src/locale/nl.js index 0a051b0e..a5a879c5 100644 --- a/account-gui/src/locale/nl.js +++ b/account-gui/src/locale/nl.js @@ -422,18 +422,9 @@ const nl = { issuers: { eherkenning: "eIDAS", idin: "Idin", - studielink: "Studielink" + studielink: "Studielink", + servicedesk: "Service Desk" } - }, - serviceDesk: { - confirmIdentityHeader: "Bevestig wie je bent met je identiteitsbewijs", - confirmIdentity: "Je kunt je identiteit ook bevestigen via een van onze eduID Service Desks.", - stepsHeader: "Volg deze stappen:", - step1: "Vul je volledige naam in zoals die op je identiteitsbewijs staat (voornamen en achternaam).", - step2: "Genereer een persoonlijke controlecode.", - step3: "Laat je controlecode en identiteitsbewijs zien aan een eduID Service Desk. Die bevestigt zo je identiteit.", - redirectWarning: "We sturen je door naar een andere website om je naam in te vullen. Je kunt daarna nog niet gelijk inloggen bij {{service}}, maar je moet eerst contact opnemen met een eduID Service Desk.", - next: "Naar gegevens invullen" } }; export default nl; \ No newline at end of file diff --git a/account-gui/src/verify/ServiceDesk.svelte b/account-gui/src/verify/ServiceDesk.svelte index 2c579875..00852402 100644 --- a/account-gui/src/verify/ServiceDesk.svelte +++ b/account-gui/src/verify/ServiceDesk.svelte @@ -91,20 +91,20 @@ toggleView()}> {@html arrowLeftIcon} -

{I18n.t("serviceDesk.confirmIdentityHeader")}

+

{I18n.t("ServiceDesk.ConfirmIdentityHeader.COPY")}

-

{I18n.t("serviceDesk.confirmIdentity")}

-

{I18n.t("serviceDesk.stepsHeader")}

+

{I18n.t("ServiceDesk.ConfirmIdentity.COPY")}

+

{I18n.t("ServiceDesk.StepsHeader.COPY")}

    -
  1. {I18n.t("serviceDesk.step1")}
  2. -
  3. {I18n.t("serviceDesk.step2")}
  4. -
  5. {I18n.t("serviceDesk.step3")}
  6. +
  7. {I18n.t("ServiceDesk.Step1.COPY")}
  8. +
  9. {I18n.t("ServiceDesk.Step2.COPY")}
  10. +
  11. {I18n.t("ServiceDesk.Step3.COPY")}
{@html alertSvg} - {@html I18n.t("serviceDesk.redirectWarning", {service: serviceName})} + {@html I18n.t("ServiceDesk.RedirectWarning.COPY", {service: serviceName})}
-