Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate deprovidioned users on login #525

Open
phavekes opened this issue Jan 23, 2025 · 0 comments
Open

Recreate deprovidioned users on login #525

phavekes opened this issue Jan 23, 2025 · 0 comments

Comments

@phavekes
Copy link
Member

phavekes commented Jan 23, 2025

When a user had been deprovisioned trough the lifecycle API, he might return later, and get the same collabpersonID.
At the moment, this causes an error:

{"message":"Exception occurred while processing command \"Surfnet\\StepupMiddleware\\CommandHandlingBundle\\Identity\\Command\\UpdateIdentityCommand[e4731040-7b60-40d4-aca9-634861466db8]\": \"Operation on this Identity is not allowed: it has been forgotten\", rolling back transaction","context":{"exception":{"class":"Surfnet\\Stepup\\Exception\\DomainException","message":"Operation on this Identity is not allowed: it has been forgotten","code":0,"file":"/var/www/html/src/Surfnet/Stepup/Identity/Identity.php:1446"}},"level":400,"level_name":"ERROR","channel":"app","datetime":"2025-01-23T15:18:54+01:00","extra":{"art":"24787","server":"middleware.test2.surfconext.nl","application":"middleware","request_id":"8bffc46f51882904a0f39a71d9d6e54b"}}
{"message":"Transaction for command \"Surfnet\\StepupMiddleware\\CommandHandlingBundle\\Identity\\Command\\UpdateIdentityCommand[e4731040-7b60-40d4-aca9-634861466db8]\" rolled back, re-throwing exception","context":{},"level":100,"level_name":"DEBUG","channel":"app","datetime":"2025-01-23T15:18:54+01:00","extra":{"server":"middleware.test2.surfconext.nl","application":"middleware","request_id":"8bffc46f51882904a0f39a71d9d6e54b"}}

If a user returns after being forgotten, we should recreate the user as if it was a new user.

@phavekes phavekes converted this from a draft issue Jan 23, 2025
@pablothedude pablothedude moved this from Backlog to In Progress in PHP development Jan 29, 2025
pablothedude added a commit that referenced this issue Feb 3, 2025
Eralier on it was not possible to restore identities after
they were forgtotten. Now logic is added to restore and reset
the tokens in the identity aggregate so the ideneity is reset.

#525
pablothedude added a commit that referenced this issue Feb 3, 2025
Earlier on it was not possible to restore identities after
they were forgotten. Now logic is added to restore and reset
the identity email, name and tokens in the identity aggregate
so the identity is reset.

#525
pablothedude added a commit that referenced this issue Feb 4, 2025
Earlier on it was not possible to restore identities after
they were forgotten. Now logic is added to restore and reset
the identity email, name and tokens in the identity aggregate
so the identity is reset.

#525
@pablothedude pablothedude moved this from In Progress to Delivered in PHP development Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Delivered
Development

No branches or pull requests

2 participants