Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header image is not shown on PyPI #585

Closed
nesnoj opened this issue Oct 11, 2024 · 3 comments · Fixed by #587
Closed

Header image is not shown on PyPI #585

nesnoj opened this issue Oct 11, 2024 · 3 comments · Fixed by #587
Assignees
@FlorianK13
Labels
🐛 bug Something isn't working

Comments

@nesnoj
Copy link
Collaborator

nesnoj commented Oct 11, 2024

Header is shown in readme but missing on PyPI: https://pypi.org/project/open-mastr/
I guess this is due to the relative path introduced in #493 , sorry for my bad advice.

Alternatively we could obtain it from RTD?
https://open-mastr.readthedocs.io/en/latest/images/README_HeaderThreePartners.svg
@nesnoj nesnoj added the 🐛 bug Something isn't working label Oct 11, 2024
@FlorianK13
Copy link
Member

Using the RTD image in the README could also be problematic, as RTD will build its docs based on the image that is in the README. This could lead to a circular dependency.

@FlorianK13
Copy link
Member

Probably using this image is the best solution: https://raw.githubusercontent.com/OpenEnergyPlatform/open-MaStR/refs/heads/production/docs/images/README_HeaderThreePartners.svg

FlorianK13 added a commit that referenced this issue Oct 23, 2024
@FlorianK13
Add static link of header image #585
d36454e
@FlorianK13 FlorianK13 linked a pull request Oct 23, 2024 that will close this issue
Add static link of header image #585 #587
Merged
5 tasks
FlorianK13 added a commit that referenced this issue Oct 23, 2024
@FlorianK13
Update CHANGELOG.md #585
45e0f56
@FlorianK13
Copy link
Member

Additionally I will try to fix the badge for CI, which is always showing failing

FlorianK13 added a commit that referenced this issue Nov 5, 2024
@FlorianK13
Repair badge of CI #585
3dde811 
I tried to adapt the style of the badge but I failed.
FlorianK13 added a commit that referenced this issue Nov 7, 2024
@FlorianK13
Merge pull request #587 from OpenEnergyPlatform/585-repair-header-image
0a07ea5 
Add static link of header image #585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FlorianK13 FlorianK13

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add static link of header image #585 OpenEnergyPlatform/open-MaStR
2 participants
@nesnoj @FlorianK13