Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP_MANIFEST_REQUEST_FAIL is never emitted #303

Open
md-proteus opened this issue Dec 10, 2018 · 2 comments
Open

APP_MANIFEST_REQUEST_FAIL is never emitted #303

md-proteus opened this issue Dec 10, 2018 · 2 comments
Labels
bug

Comments

@md-proteus
Copy link

App manifest failures, like 404s on app manifest retrievals, do not throw the expected AppHandler APP_MANIFEST_REQUEST_FAIL
@brianbaker
Copy link
Member

@pc2459 do you remember anything on this one?

@brianbaker brianbaker added the bug label Jul 20, 2021
@pc2459
Copy link
Contributor

pc2459 commented Jul 20, 2021

What is says on the tin, really. If you were loading an app and manifests retrievals weren't 200 OK, you didn't get the APP_MANIFEST_REQUEST_FAIL AppHandler fired and so you couldn't react gracefully to the failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brianbaker @pc2459 @md-proteus