bugfix: IfW rotor points for disk average incorrect #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculations for the rotor disk average wind speed use a set of point projected on the disk perpindular to the hub at ~0.7 rotor radius in the hub YZ plane. However, the indices for this calculation were incorrect and projected the points onto disk in the hub XY plane. This was discovered after one of the cases used in the curled wake paper failed to run correctly with 3.5.4 for a turbine very close to the back edge of the high resolution domain. Also added some additional information about the location of points causing outside box bound errors.
deslaughter
approved these changes
Nov 25, 2024
deslaughter
reviewed
Nov 25, 2024
| p%PositionAvg(3,i) = 0.0_ReKi | ||
| p%PositionAvg(1,i) = 0.0_ReKi ! Hub X (perpindicular to rotor plane) | ||
| p%PositionAvg(2,i) = R*cos(theta) ! Hub Y | ||
| p%PositionAvg(3,i) = R*sin(theta) ! Hub Z (in vertical plane when azimuth=0) |
There was a problem hiding this comment.
The 'ifw_turbsimffregression test is failing because it's usingR = max(1.0_ReKi, InputFileData%Uniform_RefLength)/2.0_ReKi` which is data from the wrong wind type. Maybe a rotor diameter field could be added the InflowWind driver? Or the driver could guess the rotor diameter to from the flow field size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
The calculations for the rotor disk average wind speed use a set of point projected on the disk perpendicular to the hub at ~0.7 rotor radius in the hub YZ plane. However, the indices for this calculation were incorrect and projected the points onto disk in the hub XY plane. This was discovered after one of the cases used in the curled wake paper failed to run correctly with 3.5.4 for a turbine very close to the back edge of the high resolution domain.
Also added some additional information about the location of points causing outside box bound errors.
Related issue, if one exists
Impacted areas of the software
FAST.Farm uses the disk average velocity for some calculations, so some results may change very slightly.
Additional supporting information
This was found while attempting to figure out why it was not possible to reproduce some of the curled wake results from a publication.
Test results, if applicable
Some results may change. Those will be documented below.