Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scopes validation from alchemiscale compute synchronous CLI endpoint; enforce as validator in ComputeServiceSettings #282

Open
dotsdl opened this issue Jul 23, 2024 · 0 comments

Comments

@dotsdl
Copy link
Member

dotsdl commented Jul 23, 2024

Since we are now using a pydantic model for compute service settings (ComputeServiceSettings), we can enforce a certain form for data elements using validators.

We should add a validator for scopes that allows giving them in string form. If given in that form, it should turn them into Scopes via Scope.from_str.

We can then remove external transformations currently performed in the CLI entrypoint alchemiscale compute synchronous, as well as elsewhere for other compute service implementations (such as in alchemiscale-fah).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant