Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error of exactly zero will trigger SVD failure when generating absolute values #97

Open
IAlibay opened this issue Aug 14, 2023 · 0 comments

Comments

@IAlibay
Copy link
Member

IAlibay commented Aug 14, 2023

If you somehow have an error of zero in your input to cinnabar, and then call generate_absolute_values, you'll end up with an SVD failure in np.linalg.pinv (alongside a bunch of NaN's along the way).

We should capture this edge case and ensure that folks don't feed in such values, or at least pad the number by a tiny value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant