Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add black check for PRs? #112

Closed
dotsdl opened this issue Jan 10, 2023 · 3 comments
Closed

Add black check for PRs? #112

dotsdl opened this issue Jan 10, 2023 · 3 comments
Assignees
@ianmkenney
Labels
ecosystem-standards
Milestone
Release 1.2

Comments

@dotsdl
Copy link
Member

dotsdl commented Jan 10, 2023

Should we add a black check for PRs? We have one in fah-alchemy, for example.
@dwhswenson
Copy link
Member

No. We are not Black style. We used to have pep8speaks, but apparently it stopped speaking? 🤷‍♂️

@IAlibay
Copy link
Member

IAlibay commented Jan 10, 2023

I'd vote for flake8 as a linter action, avoids the unreadable mess that black sometimes leads to (we're having issues with darken in MDA)

@dotsdl dotsdl added this to the Release 1.2 milestone Oct 15, 2024
@dotsdl dotsdl moved this to Sprint - Available in gufe : advancement sprints Oct 15, 2024
@ianmkenney ianmkenney linked a pull request Oct 15, 2024 that will close this issue
DNM Added Black formatting check action for GitHub #363
Closed
@dotsdl
Copy link
Member Author

dotsdl commented Nov 26, 2024

Closing, as we now have this.

@dotsdl dotsdl closed this as completed Nov 26, 2024
@github-project-automation github-project-automation bot moved this from Sprint - In Review to Done in gufe : advancement sprints Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianmkenney ianmkenney

Labels
ecosystem-standards
Projects
gufe : advancement sprints
Archived in project
Milestone
Release 1.2
Development

Successfully merging a pull request may close this issue.

DNM Added Black formatting check action for GitHub ianmkenney/gufe
4 participants
@dotsdl @ianmkenney @dwhswenson @IAlibay