Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsteps is incorrectly obtained from the NetCDF file #33

Open
IAlibay opened this issue Sep 17, 2024 · 0 comments
Open

nsteps is incorrectly obtained from the NetCDF file #33

IAlibay opened this issue Sep 17, 2024 · 0 comments

Comments

@IAlibay
Copy link
Member

IAlibay commented Sep 17, 2024

When calculating dt, the value for nsteps is read from online_analysis_interval which is incorrect.

See:

option_data = ds.variables['options'][0].split('\n')
for line in option_data:
if line.startswith('online_analysis_interval'):
nsteps = float(line.split()[-1])
break
else:
raise ValueError("Didn't find online_analysis_interval")

Instead it should just be calculated from the move value in the same way we do for timestep.

I.e.

for line in nc_dataset.groups['mcmc_moves']['move0'][0].split('\n'):
    if lline.split(':')[0] == 'n_steps':
        nsteps = int(line.split(':')[1])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant