Add opentelemetry.trace.propagation API #30314

yasmin-aumeeruddy · 2024-11-28T22:00:11Z

I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify release bug label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).
If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".

################################################################################################

Fixes #30258

LibbyBot · 2024-11-29T03:13:24Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

3 product code files were changed.
Please describe in a separate comment how you tested your changes.
5 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).

yasmin-aumeeruddy · 2024-11-29T09:52:23Z

#build (view Open Liberty Personal Build - ✅ completed successfully!)

LibbyBot · 2024-11-29T09:59:28Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

5 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
3 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2024-11-29T09:59:29Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

...nternal_fat/fat/src/io/openliberty/microprofile/telemetry/internal_fat/JaxRsIntegration.java

LibbyBot · 2024-11-29T11:17:24Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2024-11-29T11:17:26Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_IVsmoK47Ee-5Tq7vYMk6IA

Target locations of links might be accessible only to IBM employees.

Azquelt · 2024-11-29T11:33:41Z

...etry/internal_fat/apps/jaxrspropagation/transports/W3CTraceContextPropagatorTestServlet.java

+        assertThat(
+                   getSpanContext(w3cTraceContextPropagator.extract(Context.current(), carrier, getter)), equalTo(
+                                                                                                                  SpanContext.createFromRemoteParent(
+                                                                                                                                                     TRACE_ID_BASE16,
+                                                                                                                                                     SPAN_ID_BASE16,
+                                                                                                                                                     TraceFlags.getSampled(),
+                                                                                                                                                     TraceState.getDefault())));


Not important right now, but I'd consider adjusting the formatter settings so that it does something more sensible with this.

Co-authored-by: Andrew Rouse <[email protected]>

yasmin-aumeeruddy · 2024-12-02T10:47:43Z

#build (view Open Liberty Personal Build - ✅ completed successfully!)

LibbyBot · 2024-12-02T11:33:53Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

5 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
3 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2024-12-02T11:33:53Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2024-12-02T11:50:24Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2024-12-02T11:50:28Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_PgCWILCbEe-Q24Sd2QdBoQ

Target locations of links might be accessible only to IBM employees.

Add opentelemetry trace propagation package as API

096724b

LibbyBot added the CLA Signed label Nov 29, 2024

Azquelt reviewed Nov 29, 2024

View reviewed changes

...nternal_fat/fat/src/io/openliberty/microprofile/telemetry/internal_fat/JaxRsIntegration.java Outdated Show resolved Hide resolved

Azquelt reviewed Nov 29, 2024

View reviewed changes

Update MpTelemetry w3cTraceContextApp test set up

c8ef1b4

Co-authored-by: Andrew Rouse <[email protected]>

Azquelt approved these changes Nov 29, 2024

View reviewed changes

yasmin-aumeeruddy merged commit 1610f5f into OpenLiberty:integration Dec 4, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add opentelemetry.trace.propagation API #30314

Add opentelemetry.trace.propagation API #30314

yasmin-aumeeruddy commented Nov 28, 2024 •

edited

Loading

LibbyBot commented Nov 29, 2024

yasmin-aumeeruddy commented Nov 29, 2024 •

edited by LibbyBot

Loading

LibbyBot commented Nov 29, 2024

LibbyBot commented Nov 29, 2024

LibbyBot commented Nov 29, 2024

LibbyBot commented Nov 29, 2024

Azquelt Nov 29, 2024

yasmin-aumeeruddy commented Dec 2, 2024 •

edited by LibbyBot

Loading

LibbyBot commented Dec 2, 2024

LibbyBot commented Dec 2, 2024

LibbyBot commented Dec 2, 2024

LibbyBot commented Dec 2, 2024

Add opentelemetry.trace.propagation API #30314

Add opentelemetry.trace.propagation API #30314

Conversation

yasmin-aumeeruddy commented Nov 28, 2024 • edited Loading

LibbyBot commented Nov 29, 2024

Code analysis and actions

yasmin-aumeeruddy commented Nov 29, 2024 • edited by LibbyBot Loading

LibbyBot commented Nov 29, 2024

Code analysis and actions

LibbyBot commented Nov 29, 2024

LibbyBot commented Nov 29, 2024

LibbyBot commented Nov 29, 2024

Azquelt Nov 29, 2024

Choose a reason for hiding this comment

yasmin-aumeeruddy commented Dec 2, 2024 • edited by LibbyBot Loading

LibbyBot commented Dec 2, 2024

Code analysis and actions

LibbyBot commented Dec 2, 2024

LibbyBot commented Dec 2, 2024

LibbyBot commented Dec 2, 2024

yasmin-aumeeruddy commented Nov 28, 2024 •

edited

Loading

yasmin-aumeeruddy commented Nov 29, 2024 •

edited by LibbyBot

Loading

yasmin-aumeeruddy commented Dec 2, 2024 •

edited by LibbyBot

Loading