Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Old-style" radius ench not applied when moving between two rooms with a spell cast by the same player. #1242

Open
skittles1 opened this issue Oct 17, 2015 · 0 comments

Comments

@skittles1
Copy link

Rather than fix this issue directly, RadiusEnchantment (and subclasses) should instead be refactored so that rooms are keeping track of what enchantments are active and who should be affected. Having the spells do this is adding a layer of abstraction to the enchantment calculation that doesn't need to be there, as all radius (area) enchantments are by definition performed in a room. This would simplify the process of adding and removing the enchantments and determining who is in range of the source, and spells can be queried with a simple "is X affected if Y is the caster", some of which can use the existing Spell infrastructure for checking whether one battler can attack another.

This should be the next step in work on radius enchantments, before any more modifications are done to that class.

@skittles1 skittles1 added this to the 1.0.17.0 milestone Oct 17, 2015
@treymd treymd modified the milestone: 1.0.17.0 Oct 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants