You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rather than fix this issue directly, RadiusEnchantment (and subclasses) should instead be refactored so that rooms are keeping track of what enchantments are active and who should be affected. Having the spells do this is adding a layer of abstraction to the enchantment calculation that doesn't need to be there, as all radius (area) enchantments are by definition performed in a room. This would simplify the process of adding and removing the enchantments and determining who is in range of the source, and spells can be queried with a simple "is X affected if Y is the caster", some of which can use the existing Spell infrastructure for checking whether one battler can attack another.
This should be the next step in work on radius enchantments, before any more modifications are done to that class.
The text was updated successfully, but these errors were encountered:
Rather than fix this issue directly, RadiusEnchantment (and subclasses) should instead be refactored so that rooms are keeping track of what enchantments are active and who should be affected. Having the spells do this is adding a layer of abstraction to the enchantment calculation that doesn't need to be there, as all radius (area) enchantments are by definition performed in a room. This would simplify the process of adding and removing the enchantments and determining who is in range of the source, and spells can be queried with a simple "is X affected if Y is the caster", some of which can use the existing Spell infrastructure for checking whether one battler can attack another.
This should be the next step in work on radius enchantments, before any more modifications are done to that class.
The text was updated successfully, but these errors were encountered: