Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU_INCLUDE_DIRS for cli projects #331

Open
emabiz opened this issue Jul 15, 2024 · 0 comments
Open

ICU_INCLUDE_DIRS for cli projects #331

emabiz opened this issue Jul 15, 2024 · 0 comments

Comments

@emabiz
Copy link

emabiz commented Jul 15, 2024

Hi,
first of all thank you for your work about Tokenizer and CTranslate2.

I tried to compile Tokenizer under win10.
It works fine except I had to modify the include part in the main CmakeLists.txt

set(INCLUDE_DIRECTORIES
  PUBLIC
  ${CMAKE_CURRENT_SOURCE_DIR}/include
  ${PROJECT_BINARY_DIR}
  ${ICU_INCLUDE_DIRS}

  PRIVATE  
  ${CMAKE_CURRENT_SOURCE_DIR}/third_party/sentencepiece/src
  )

putting ${ICU_INCLUDE_DIRS} in the public section, because it is used also by cli projects and putting it in the private section doesn't propagate the value to these projects.
Is it expected?

Emanuele

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant