Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests should use Gateway/CoGateway interaction helpers #721

Open
abhayks1 opened this issue Apr 26, 2019 · 2 comments
Open

Integration tests should use Gateway/CoGateway interaction helpers #721

abhayks1 opened this issue Apr 26, 2019 · 2 comments

Comments

@abhayks1
Copy link
Contributor

abhayks1 commented Apr 26, 2019

Context

Both MPP generator tool and Integration tests does stake & mint and redeem & unstake flow.
In MPP generator tool Gateway and CoGateway interaction methods has been refactored to helpers: *mosaic-contracts/proof_generation/helper/ **

For usability perspective and to avoid repeated code it makes sense for integration tests to use these helpers 📚 .
Refer discussion: #717 (comment)

Proposal

  • Decide on ideal location for these helpers as currently they sit in proof_generation folder.

  • Make changes in the helpers so that they are usable both for the tool 🔧 and integration tests.

  • Update the caller code accordingly.

The ticket should be done after below PR is merged:
#717

@benjaminbollen
Copy link
Contributor

#717 (comment)

Will create a ticket to integrate proof generator with truffle exec 👍

will wait for this ticket before moving this ticket forward.

@abhayks1
Copy link
Contributor Author

Ticket created: #731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants