Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Updated osi-visualizer to handle ZMQ Push/Pull configuration in LiME #34

Merged
merged 5 commits into from
Oct 10, 2019
Merged

Updated osi-visualizer to handle ZMQ Push/Pull configuration in LiME #34

merged 5 commits into from
Oct 10, 2019

Conversation

nreischl
Copy link
Contributor

No description provided.

@ghost ghost requested a review from pmai January 30, 2019 18:01
@ghost ghost added the feature request Proposals which enhance the interface or add additional features. label Jan 30, 2019
@ghost ghost assigned pmai Mar 5, 2019
@ghost
Copy link

ghost commented Apr 4, 2019

Bump: @nreischl

I am back on Github again. Is this up-to-date?

@nreischl
Copy link
Contributor Author

nreischl commented Apr 4, 2019

Up-to-date with the current LiME development.

@ghost
Copy link

ghost commented Apr 4, 2019

@pmai as discussed you are doing this and I #32

@jdsika jdsika requested review from jdsika and removed request for pmai September 19, 2019 09:15
jdsika
jdsika approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@jdsika jdsika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkresch please test before merge. I just approve in order not to block your work here as Altran intends to contribute actively to this open source tool.

@vkresch vkresch merged commit 055df99 into OpenSimulationInterface:master Oct 10, 2019
@vkresch
Copy link
Contributor

vkresch commented Oct 10, 2019

Tested and works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jdsika jdsika jdsika approved these changes

Assignees

@pmai pmai

Labels
feature request Proposals which enhance the interface or add additional features.
Projects
None yet
Milestone
Visualizer Support for OSI 2.2.x and ...
Development

Successfully merging this pull request may close these issues.
4 participants
@nreischl @vkresch @jdsika @pmai