Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: auto-volume #25

Open
JarbasAl opened this issue Dec 11, 2023 · 1 comment
Open

feature request: auto-volume #25

JarbasAl opened this issue Dec 11, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@JarbasAl
Copy link
Member

should have native functionality equivalent to this skill https://github.com/andlo/auto-volume-skill

enabled via config

@JarbasAl JarbasAl added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 6, 2025
@andlo
Copy link

andlo commented Jan 7, 2025

I have some questions about how to imlement this....

First - how to get the mic level - in mycroft it cpuld be read from a file, but cant se the same under OVOS.

Second - should it be an extension to this PHA L plugin like
self.bus.on("mycroft.volume.auto", self.handle_auto_request)

and third- should there be a autovolume skill to take care of the voice to activate and deactivate or should that be added to the volume skill - i think it shod be added to volume skill.

and forth - should the listning on the mic level be in PHAL or the controling skill

It is som years ago i made the auto-volume skill, but it were fun then and can be fun to add feature to OVOS to.
The auto-volume skill made frequent reading of mic level and took the median level and set the volume acording to that. There are need of multiple readings to make sure we dont think there are much noise jyst because last reading were when someobe slamed a dor or sneesed or droped someting on the flor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants