-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/openpdd sidebar template #24
base: mijn-zaken/frontend
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is full of lorum-ipsum,
since sidebar should work with the content from the content-blocks. But wanted to fix the JS for this logic first.
3de66f8
to
7f9d44a
Compare
3b5b6e8
to
ec58100
Compare
7f9d44a
to
abc7d61
Compare
ec58100
to
63279fe
Compare
Hoi Paul, er waren flink wat changes in master dus ik heb de vrijheid genomen om jouw branch uit te checken en de rebase goed te regelen. Dat scheelt je in ieder geval veel gezeik :-) Fijne toevoegingen dit! Zou jij alles wat te maken heeft met de collapsible componenten uit deze PR willen halen en er een aparte PR voor kunnen maken? Dan kunnen de changes voor de sidebar template gemerged worden in Extra info over de changes van master: alle configuratie is naar de root verhuisd. Daar moet je vanaf nu een |
</a> | ||
</li> | ||
<li class="denhaag-sidenav__item"> | ||
<a href="#mijn-berichten" class="denhaag-sidenav__link"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kun je alle links in deze file voor nu hardcoded naar de desbetreffende slug verwijzen?
<?php echo home_url('mijn-berichten'); ?>
2bcbbe3
to
48d6680
Compare
e3d115c
to
6611ca7
Compare
6611ca7
to
2d4662a
Compare
8a7db0c
to
4d040df
Compare
c8d3d8f
to
03c6778
Compare
5c9e055
to
412bd7e
Compare
3c9841c
to
7c6a0ab
Compare
fdc044c
to
a726a42
Compare
7d3e9d8
to
09105dc
Compare
09105dc
to
6b5b9ef
Compare
This is still a work in progress,
after_switch_theme
action, due to breaking the WordPress template hierarchy;