Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/openpdd sidebar template #24

Draft
wants to merge 11 commits into
base: mijn-zaken/frontend
Choose a base branch
from

Conversation

paulAcato
Copy link
Collaborator

This is still a work in progress,

  • excluded the after_switch_theme action, due to breaking the WordPress template hierarchy;
  • Manualy copy-pasted the NLDS DH blocks CSS instead of an import, now my node_modules are broken (since i'm missing a premium licence);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is full of lorum-ipsum,

since sidebar should work with the content from the content-blocks. But wanted to fix the JS for this logic first.

@paulAcato paulAcato changed the base branch from master to mijn-zaken/frontend October 10, 2023 08:01
@YvetteNikolov YvetteNikolov force-pushed the feature/openpdd-sidebar-template branch from ec58100 to 63279fe Compare October 11, 2023 08:46
@YvetteNikolov
Copy link
Contributor

Hoi Paul, er waren flink wat changes in master dus ik heb de vrijheid genomen om jouw branch uit te checken en de rebase goed te regelen. Dat scheelt je in ieder geval veel gezeik :-)

Fijne toevoegingen dit! Zou jij alles wat te maken heeft met de collapsible componenten uit deze PR willen halen en er een aparte PR voor kunnen maken? Dan kunnen de changes voor de sidebar template gemerged worden in mijn-zaken/frontend.

Extra info over de changes van master: alle configuratie is naar de root verhuisd. Daar moet je vanaf nu een npm install & npm start runnen, in plaats van in /themes/. Zie ook de README.

</a>
</li>
<li class="denhaag-sidenav__item">
<a href="#mijn-berichten" class="denhaag-sidenav__link">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kun je alle links in deze file voor nu hardcoded naar de desbetreffende slug verwijzen?

<?php echo home_url('mijn-berichten'); ?>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants