Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success Response is wrong, Webhooks are unreliable #384

Open
reneroth opened this issue Jan 3, 2025 · 0 comments
Open

Success Response is wrong, Webhooks are unreliable #384

reneroth opened this issue Jan 3, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@reneroth
Copy link

reneroth commented Jan 3, 2025

Analysis

Triggering a command via API will always return "success" immediately, even if it fails due to e.g. running out of battery or the gateway having lost network connection. There is no way for us to know if a command actually succeeded, or if a scene stopped halfway through, etc.

see this issue for more info: #258

Expected Behavior

I need to be able to see if a command has actually been executed. The mobile app can already show that info.
It would be enough of the webhook would a) return an event for such failures or b) the "timeout" and related behaviour was well documented. As it is now, not even the available events seem documented thoroughly.

Steps To Reproduce

  1. take the battery out of a device
  2. trigger an action from the api
  3. see "success" response, notice there are no inbound webhooks, no way for us as devs to know what is going on
  4. open iphone app, see the app is well aware that a request has failed

Logs

n/a

Configuration

stock config

Environment

doesnt matter, REST API

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants