Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation Failure When Using clang and Enabling RVB & PERF_OPT #366

Open
cebarobot opened this issue Jun 19, 2024 · 0 comments
Open

Compilation Failure When Using clang and Enabling RVB & PERF_OPT #366

cebarobot opened this issue Jun 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@cebarobot
Copy link
Member

clang is not happy with current RVB implementation when perfomance optimization, because:

  • NEMU defines some functions in src/isa/riscv64/instr/rvb/rvintrin.h.
  • rvintrin.h is included in file src/isa/riscv64/instr/rvb/exec.h.
  • rvb/exec.h is included in file src/isa/riscv64/include/isa-exec.h.
  • isa-exec.h is included in function execute() in file src/cpu/cpu-exec.c, when perfomance optimization is enabled.

So that there is some functions are defined in another function, which clang complained about.

Also, rvintrin.h is really weird. It has another copyright header. I think this file is from here, but the two files are very different.

I think we should rewrite the implementation of RVB.

@cebarobot cebarobot added the bug Something isn't working label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant