We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clang is not happy with current RVB implementation when perfomance optimization, because:
src/isa/riscv64/instr/rvb/rvintrin.h
rvintrin.h
src/isa/riscv64/instr/rvb/exec.h
rvb/exec.h
src/isa/riscv64/include/isa-exec.h
isa-exec.h
execute()
src/cpu/cpu-exec.c
So that there is some functions are defined in another function, which clang complained about.
Also, rvintrin.h is really weird. It has another copyright header. I think this file is from here, but the two files are very different.
I think we should rewrite the implementation of RVB.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
clang is not happy with current RVB implementation when perfomance optimization, because:
src/isa/riscv64/instr/rvb/rvintrin.h
.rvintrin.h
is included in filesrc/isa/riscv64/instr/rvb/exec.h
.rvb/exec.h
is included in filesrc/isa/riscv64/include/isa-exec.h
.isa-exec.h
is included in functionexecute()
in filesrc/cpu/cpu-exec.c
, when perfomance optimization is enabled.So that there is some functions are defined in another function, which clang complained about.
Also,
rvintrin.h
is really weird. It has another copyright header. I think this file is from here, but the two files are very different.I think we should rewrite the implementation of RVB.
The text was updated successfully, but these errors were encountered: