Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pausable for erc721 #212

Open
1 task done
qalisander opened this issue Jul 24, 2024 · 0 comments · May be fixed by #414
Open
1 task done

Refactor pausable for erc721 #212

qalisander opened this issue Jul 24, 2024 · 0 comments · May be fixed by #414
Assignees
@0xNeshi
Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will resolve this in a short timeframe. type: docs Changes to documentation. type: feature New feature request.

Comments

@qalisander
Copy link
Member

What is the feature you would like to see?

Try to apply an approach similar to consecutive implementation for erc721. But for pausable extension.
Implement PausableErc721 contract that duplicates functions from erc721 that are necessary to be overridden. (just _update in the context of pausable extension)
And duplicate functions that depend on _update also.

p.s. potentially can help if stylus sdk team will force to have unique selectors.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@qalisander qalisander added type: feature New feature request. needs triage Needs to be assigned the appropriate labels labels Jul 24, 2024
@alexfertel alexfertel added priority: 2 We will resolve this in a short timeframe. type: docs Changes to documentation. effort: low Easy or tiny task that takes less than a day. and removed needs triage Needs to be assigned the appropriate labels labels Aug 1, 2024
@0xNeshi 0xNeshi self-assigned this Nov 20, 2024
@0xNeshi 0xNeshi linked a pull request Nov 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xNeshi 0xNeshi

Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will resolve this in a short timeframe. type: docs Changes to documentation. type: feature New feature request.
Projects
Rust Contracts Stylus
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Refactor pausable for erc721 example OpenZeppelin/rust-contracts-stylus
3 participants
@0xNeshi @alexfertel @qalisander