refactor(test): migrate unit tests to the new motsu layout #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontract-deployment
✅ Deploy Preview for contracts-stylus canceled.
|
qalisander
commented
Nov 28, 2024
qalisander
commented
Nov 28, 2024
contracts/src/token/erc721/mod.rs
Outdated
Comment on lines
2547
to
2562
| #[motsu::test] | ||
| fn on_erc721_received( | ||
| erc721: Contract<Erc721>, | ||
| receiver: Contract<Erc721ReceiverMock>, | ||
| ) { | ||
| let alice = Account::random(); | ||
| let token_id = random_token_id(); | ||
| erc721 | ||
| .sender(alice) | ||
| ._safe_mint(receiver.address(), token_id, vec![0, 1, 2, 3].into()) | ||
| .unwrap(); | ||
|
|
||
| let received_token_id = receiver.sender(alice).received_token_id(); | ||
|
|
||
| assert_eq!(received_token_id, token_id); | ||
| } |
There was a problem hiding this comment.
Overall the test case for Erc721Receiver can look like this
1 task
bidzyyys
reviewed
Feb 6, 2025
bidzyyys
changed the title
0xNeshi
approved these changes
Feb 6, 2025
Comment on lines
+407
to
+408
| let (token_ids, values) = | ||
| contract.init(alice, |contract| init(contract, bob, 1)); |
There was a problem hiding this comment.
Tbh this looks less clear compared to doing the same manually:
let mut callable = contract.sender(alice);
let (token_ids, values) = init(&mut callable, bob, 1);
0xNeshi
reviewed
Feb 6, 2025
3 tasks
1 task
bidzyyys
approved these changes
Feb 11, 2025
|
I think it's safe to merge this PR, as it doesn't rely on e2e tests, only on unit tests (which pass) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr contains migration of unit test to the new layout of motsu unit tests, that will be introduced in OpenZeppelin/stylus-test-helpers#8 and OpenZeppelin/stylus-test-helpers#12
Resolves #470
PR Checklist