From 02cfe7d8f4bc35fe976ff490422a04e45b6b02bf Mon Sep 17 00:00:00 2001 From: NielsJPeschel Date: Wed, 5 Jun 2024 14:42:37 -0400 Subject: [PATCH 1/2] Fix: handle null cases in callback functions --- hooks/useLoadData/callbacks/complete/complete.ts | 2 +- hooks/useLoadData/callbacks/success/success.ts | 2 +- package.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hooks/useLoadData/callbacks/complete/complete.ts b/hooks/useLoadData/callbacks/complete/complete.ts index cd3524e..7435730 100644 --- a/hooks/useLoadData/callbacks/complete/complete.ts +++ b/hooks/useLoadData/callbacks/complete/complete.ts @@ -2,7 +2,7 @@ export function complete(onSuccess?: (data: T) => void, onError?: (error: unk return (err?: unknown, res?: T) => { if (err) { onError?.(err); - } else if (res) { + } else if (res || res === null) { onSuccess?.(res); } }; diff --git a/hooks/useLoadData/callbacks/success/success.ts b/hooks/useLoadData/callbacks/success/success.ts index 72aecff..ae4e297 100644 --- a/hooks/useLoadData/callbacks/success/success.ts +++ b/hooks/useLoadData/callbacks/success/success.ts @@ -1,6 +1,6 @@ export function success(onSuccess?: (data: T) => void) { return (err?: unknown, res?: T) => { - if (res) { + if (res || res === null) { onSuccess?.(res); } }; diff --git a/package.json b/package.json index 371629c..99385ef 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@optum/react-hooks", - "version": "1.0.3", + "version": "1.0.4", "description": "A reusable set of React hooks", "repository": "https://github.com/Optum/react-hooks", "license": "Apache 2.0", From 5fbbb2b3d09d5e5f6b1a5a615e5d0ceeeeaba5d1 Mon Sep 17 00:00:00 2001 From: NielsJPeschel Date: Tue, 22 Oct 2024 10:17:03 -0400 Subject: [PATCH 2/2] updated version to next --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 99385ef..f0c8a3b 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@optum/react-hooks", - "version": "1.0.4", + "version": "1.0.3-next.1", "description": "A reusable set of React hooks", "repository": "https://github.com/Optum/react-hooks", "license": "Apache 2.0",