Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automated tests / CI improvements #5

Open
OriHoch opened this issue May 7, 2017 · 3 comments
Open

automated tests / CI improvements #5

OriHoch opened this issue May 7, 2017 · 3 comments

Comments

@OriHoch
Copy link
Owner

OriHoch commented May 7, 2017

TODO

  • currently we have travis run multiple python versions, need to determine if the versions it's running are ok (I think we need to add python 3.6)
  • should update to use tox
  • should remove the tests from the published package
  • should run the tests using standard test runner (e.g. pytest or python -m unittest)
  • should have automatic publishing to pypi when github release is published. something like this - https://github.com/hasadna/knesset-data-python/blob/master/.travis/after_success.sh
@OriHoch
Copy link
Owner Author

OriHoch commented May 7, 2017

could split this issue into sub-issues for each bullet..

@ninjaaron
Copy link
Collaborator

ninjaaron commented May 7, 2017

I'm pretty much a newb when it comes to CI anything, so I'll have to read up about Travis and Tox when I get the time. As far as 3.6, that along with 2.7 are the only python versions I have locally, so I'm sure to know when they don't work!

Whenever I get to reading about Travis and tox, I'll let you know if I have any ideas, but keep me posted if you need me to do something before that.

@ninjaaron
Copy link
Collaborator

I'll work on moving the tests out of the package and getting them to run with python -m unittest. Low hanging fruit. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants