Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

Create options object with callbacks #555

Open
sparrowDom opened this issue Sep 26, 2018 · 0 comments
Open

Create options object with callbacks #555

sparrowDom opened this issue Sep 26, 2018 · 0 comments
Assignees
@sparrowDom
Labels
enhancement New feature or request javascript origin.js

Comments

@sparrowDom
Copy link
Member

As a proper rework of the idea tested in this PR: #546 we should have an options object parameter in each origin-js method that has optional properties transactionHashCallback & confirmationCallback. In an attempt to unify the api approach how we deal with calls that result in ethereum transactions.
@sparrowDom sparrowDom self-assigned this Sep 26, 2018
@sparrowDom sparrowDom mentioned this issue Sep 26, 2018
Merged
3 tasks
@micahalcorn micahalcorn added enhancement New feature or request javascript labels Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sparrowDom sparrowDom

Labels
enhancement New feature or request javascript origin.js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@micahalcorn @sparrowDom