Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split sdba #2099

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Split sdba #2099

wants to merge 2 commits into from

Conversation

coxipi
Copy link
Contributor

@coxipi coxipi commented Mar 5, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • ...

Does this PR introduce a breaking change?

Other information:

We must remove sdba-warning.yml , yes?

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Mar 5, 2025

Warning

This Pull Request modifies the SDBA module.
The SDBA module is gradually being deprecated in favour of the xsdba package.
Any changes to xclim.sdba should be made in https://github.com/Ouranosinc/xsdba

@github-actions github-actions bot added information For development/intsructional purposes sdba Issues concerning the sdba submodule. docs Improvements to documenation labels Mar 5, 2025
@coxipi
Copy link
Contributor Author

coxipi commented Mar 5, 2025

Should have I kept the sdba tests? now I think of it, it would be useful to have them to test xsdba integration in xclim.

@Zeitsperre
Copy link
Collaborator

Should have I kept the sdba tests? now I think of it, it would be useful to have them to test xsdba integration in xclim.

We kept the tests around for the GIS component for about a year, despite there being little reason for it. I wouldn't suggest us doing that again.

It might be worthwhile to only keep the tests that rely on both xclim and xsdba as an assurance? W would also test to make sure that the proper warnings/errors are being emitted in the event that xsdba is not installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements to documenation information For development/intsructional purposes sdba Issues concerning the sdba submodule.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants