Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-10774: Fix additional spaces when adding a new class to cssClass and cssClassAll #427

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

OS-giulianasilva
Copy link
Contributor

This PR is to fix the additional spaces when adding a new class to cssClass and cssClassAll.

What was done

  • Check if classList is not empty before splitting the string into an array. If empty, return a empty array.

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@OS-giulianasilva OS-giulianasilva requested a review from a team as a code owner July 26, 2024 17:06
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@OS-giulianasilva OS-giulianasilva merged commit 36a275f into dev Jul 31, 2024
7 of 13 checks passed
@OS-giulianasilva OS-giulianasilva deleted the ROU-10774 branch July 31, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants