Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View on <video site> link #254

Open
mblomdahl opened this issue Dec 13, 2024 · 6 comments
Open

View on <video site> link #254

mblomdahl opened this issue Dec 13, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request figma alignment For issues and PRs that should be shared with Mikael, for aligning Figma designs

Comments

@mblomdahl
Copy link
Contributor

mblomdahl commented Dec 13, 2024

We do not want to give the impression that we're "stealing" the user experience from any video site, there should be an easy way to navigate to the PeerTube site for additional features like reading comments, logging in, liking videos, et cetera.

In the top-right corner next to the "share" button, we should add something like this:

image

And same on the landing page of an individual Channel or Playlist, "View channel on videos.blender.org ". The link should open the channel/playlist/video in a new tab in browser, or open the OS default browser on Android/iOS. On TV on the other hand, there's no browser so maybe some kind of attribution instead...

@mblomdahl mblomdahl added enhancement New feature or request figma alignment For issues and PRs that should be shared with Mikael, for aligning Figma designs labels Dec 13, 2024
@mkl-adsn
Copy link

@mblomdahl To not bloat the player too much with features not aimed towards the avarage user, I would suggest adding it to the bottom of the description insead: https://www.figma.com/design/f15L42P8qyLqNkzm0Eeo8G/Owntube?node-id=90-2708&t=OQxujiwVLj05HT8m-1

For channel/playlists I also think it will be very prominent to have it at the top as it will be the first thing the user sees. I can add it if you want but to me it this feature doesn't make that much sense.

@mkl-adsn mkl-adsn moved this from Todo to In Progress in Embeddable React Native Client Dec 15, 2024
@mblomdahl
Copy link
Contributor Author

@mblomdahl To not bloat the player too much with features not aimed towards the avarage user, I would suggest adding it to the bottom of the description insead: https://www.figma.com/design/f15L42P8qyLqNkzm0Eeo8G/Owntube?node-id=90-2708&t=OQxujiwVLj05HT8m-1

For channel/playlists I also think it will be very prominent to have it at the top as it will be the first thing the user sees. I can add it if you want but to me it this feature doesn't make that much sense.

This does not make so much sense at the channel/playlist level, there it does not need to be so prominent. But in the video player view there's a bunch of things that we won't support anytime soon; donate, like, dislike, comment, reply to comments, next/previous video, download video, download audio, download subtitles, add to (own) playlist et cetera. The idea here is to shut down complaints about missing features by referring to the easily-accessible "View on video.blender.org" which enables the full user experience with all available PeerTube features.

@mkl-adsn
Copy link

@mblomdahl I feel the top of player have a lot of different interactive elements already. It's especially noticable on mobile where adding an additional link would be very tight, I suggest to put the link in the bottom right insted where we have space for it on both desktop and mobile. As for the link prominence, I'm leaning towards using a slightly more transparent white compared to the rest of the player ui elements, but it would also work having the same transparency as the rest, both variants are available in the Figma for you to review: https://www.figma.com/design/f15L42P8qyLqNkzm0Eeo8G/Owntube?node-id=12-2107&t=QI1djKTdaUOp37Ch-1

@mblomdahl
Copy link
Contributor Author

mblomdahl commented Dec 24, 2024

@mkl-adsn Good idea, bottom right is good! But a bit more spacious layout would be good to avoid people with big hands "fat-fingering" on the link when trying to use the scroll bar. Just keep in mind we'll also have to add some additional controls in the bottom-right apart from the current full screen.

  • "CC" captions button on/off
  • Settings for playback speed, subtitle language selection, resolution selection
  • AirPlay or Chromecast (depending on platform)
  • Full screen

Illustration:
image

@mykhailodanilenko
Copy link
Contributor

@mkl-adsn @mblomdahl where did we land on having a link on playlist/channel pages?

@mkl-adsn
Copy link

@mykhailodanilenko I think we decided no, but currect me if I'm wrong @mblomdahl

@mblomdahl I've added design for the additional controls as well now. Once we implement it I suggest we move the current settings button from the top right to the new menu and split it up into two options, "Debug" and "Language" respectevely. Please see the figma prototype and let me know what you think:
https://www.figma.com/proto/f15L42P8qyLqNkzm0Eeo8G/Owntube?page-id=0%3A1&node-id=12-2107&node-type=canvas&viewport=-1133%2C1285%2C0.64&t=FsCLJa6pNWhUtaj6-1&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=116%3A4865&show-proto-sidebar=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request figma alignment For issues and PRs that should be shared with Mikael, for aligning Figma designs
Projects
Status: In Progress
Development

No branches or pull requests

3 participants