-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue overlaps player controls #951
Comments
Cannot reproduce on Sony Xperia 1 V; Android 14
|
Maybe is a Xiaomi HyperOS thing? |
Maybe, but I just got a software update, probably to Android 15. I'll try again soon. |
Yeah, this is a HyperOS regression because it probably broke WindowInsets support at some point for unknown reasons. Nothing I can do but test random in-development builds until the error appears @VoxelPrismatic. |
Can you try all of the debug APKs in these ZIP files and report if any of them have the UI bug @gabeweb? Auxio_fc90d46.zip |
Sure, let me try them all out. |
Okay, I tried all the APKs and everything was fine. I noticed that the first version had excessive padding, while the other three did not. The following are the screenshots in the same order as the ZIP list:
|
Okay @gabeweb, can you just try the latest debug build? Pretty much all of the major inset changes were done in that version so I need to rule out this being some kind of weird release/debug discrepancy. |
I really don't know what to do here @gabeweb. This is very likely a HyperOS issue triggered only by timing differences between release and debug builds. |
When I switch the app's theme (from Dark to Light or vice versa, instead of using Auto), the queue list temporarily overlaps the controls. This only happens immediately after changing the theme. Closing and reopening the app resolves the issue. |
And this doesn't occur on any of the other debug builds I provided earlier @gabeweb? |
I can actually reproduce this one |
Let me try. |
Please try the debug builds @VoxelPrismatic |
Tested again:
And nothing of them has the issue presented in the Canary version. |
crash info
actions for crash. you must enter a sub-panel.
screen-20250109-145501.mp4If you are able to go back, the app slows horrendously and canary comes to investigate ram leaks |
Okay, so it actually seems to be something that occured later in development. Given that this occurred after the window inset changes, my guess is a dependency upgrade broke something @VoxelPrismatic @gabeweb, will get another set of debug builds. |
Try this out @gabeweb @VoxelPrismatic Also: The crash you reported is a problem with navigation's predictive back support, it's the reason why I've disabled it. It's just in the commit history I've turned it on and off to see if the bugs have been fixed yet. |
Nope. Still breaks after the theme change. And round mode is still enforced. Also, the first time I opened the menu, it crashed.screen-20250109-212521.mp4
Resolves after selecting a track to play. |
I know, its an old debug build I grabbed to reduce the space in which the issue was introduced. Will need to find an older build apparently. |
The plot thickens |
Commit de36 is still tagged as 4.0.0-dev3 |
de36 is technically part of all of the commits between 3.6.3 and 4.0.0, hence the tag. this is generally where im searching for the bug. |
Oh you checkout that commit and build every time. I thought you had some CI/CD that built on every commit. I wish I could help more, but that will take significant time so I can get familiar with the codebase. |
Not really, GitHub does CI/CD on every push and keeps the apk around for a good while before discarding it. Eventually you have to clone and build yourself though, which is annoying. Auxio should mostly be buildable in Android Studio but older revisions require you to sync up the submodules and whatnot. |
I'll keep testing on more devices that I have. I'll let you know what pops up. |
Onyx Boox Note 4C (Android 14) - Works as expected |
I'm just wondering why the Android 14 APK works fine, but the Android 15 one does not. What changes between the two? |
As far as I am aware @VoxelPrismatic, it's some kind of strange timing difference between either an upgraded dependency or a platform compatibility change. Here is one more last ditch attempt to see what's going on now @VoxelPrismatic, can you take logs on this? Specifically try to filter only logs containing |
Curiously, it stops logging. screen-20250111-110339.mp4 |
It might also be logging but with the same information repeatedly @VoxelPrismatic, try this, should log with random numbers to see if its doing anything new |
Nope. Stops logging after entering the settings panel. screen-20250111-110845.mp4 |
............... @VoxelPrismatic |
I think I know what the issue is now @VoxelPrismatic. I think your view never receives WindowInsets once you make that theme change for some inexplicable reason. Log on this so I can tell: In this case, I will need to probably set up a bunch of logging at various WindowInsets locations to see why it's never went. |
Anything I should log for specifically? |
|
Null, curiously. screen-20250111-111753.mp4 |
Knew it @VoxelPrismatic, the playback panel never recieves the window insets! But the rest of the app does given that nothing else slides beneath the playback bar or status bars. Will get back later with another build that logs the flow of window insets to see at what point it breaks down. |
Please take logs over this @VoxelPrismatic, filter for |
screen-20250113-123430.mp4 |
Wait, I think I see the problem now. Your theme change winds up causing the system to change the whole app into non-edge to edge mode, which then means that WindowInsets are no longer delivered. Moreover, since the app now targets Android 15, edge to edge is now auto-enabled, and apparently the OS doesn't realize that Auxio indicates it supports edge to edge. I probably need to add another handful of magic flags to accomodate some busted OEM logic additions, don't I... |
This build dumpsters my current edge to edge flags and uses the "new" way of enabling edge to edge @VoxelPrismatic. |
I finally figured out how to log only Auxio, apparently selecting no log levels doesn't default to all of them. Anyway, still doesn't work. screen-20250113-125013.mp4 |
Okay, I'm doing nothing wrong here at this point @VoxelPrismatic. Your system is broken and refusing to handle edge to edge correctly. Perhaps if I change the way I retheme the app on a settings change it'll stop the issue on your system, as for @gabeweb he needs to report the issue to Xiaomi since it's their broken ROM. |
Out of curiosity, what happens if you completely disable edge to edge? |
Before Android 15? System insets kick in and likely cause bug @VoxelPrismatic. Android 15+? Edge to edge is automatically enabled, window insets sent. The problem is that the Sony ROM and HyperOS sometimes turns off edge to edge and thus disables the window insets being sent to the app, even though my app expects those WindowInsets being given and has no way to gracefully degrade since it functionally cannot tell if it's been shoved into non-edge to edge mode. Please test that build when you can |
Closing since this is an unfixable system bug. |
This resolved it for me LOL |
The issue does re-appear when resizing the window, but I won't pester you any further with that because it is largely ROM based at that point. |
Seems like on your device doing any "configuration change" triggers the bug @VoxelPrismatic. No idea what causes it on @gabeweb's device, doubt I'll be able to know. |
Hi, let met try the Hacky6 file. |
Ok, in the Hacky6 file, everything seems to work correctly except for the following:
Therefore, the only issue I'm facing is the queue overlap that occurs specifically when switching from the "Auto" theme to "Dark" or "Light" within the Auxio app. When I have the "Auto" theme and change "light" or "dark" mode in the system, I haven't any issue. And when I quickly exit from Appearance settings, the app doesn't crashes also. The same when I change from portrait to landscape modes, and vice-versa, no issues present. So, the only issue here is when changing from "Auto" to dark or light theme then the queue overlaps again. |
Playing whatever, from playlist, album, artist, etc., on the Now playing screen, the queue list overlaps player controls.
However, the lastest stable version (from F-Droid) hasn't that issue but the padding is "too much" (I think):
Redmi Note 13 4G (HyperOS 2.0.4 / Android 15.0)
The text was updated successfully, but these errors were encountered: