Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Songs are skipped when player URL is out of date #56

Open
kmac opened this issue May 12, 2022 · 0 comments
Open

Songs are skipped when player URL is out of date #56

kmac opened this issue May 12, 2022 · 0 comments

Comments

@kmac
Copy link
Contributor

kmac commented May 12, 2022

The current handling of the case where we get a 403 when playing a song is to queue a player refresh and report the error. This results in the song being skipped. I usually listen to albums so this is very noticeable to me when it happens.

Looking at the implementation around the

mopidy-ytmusic/mopidy_ytmusic/playback.py

Line 166 in cc5e147

# It's forbidden. Likely because the player url changed and we

I'm wondering if it's feasible to refresh the player inline and retry. I'll likely give this a go, but if anyone has ideas around a better approach here I would appreciate any input. I'm new to this project so I'd like to understand a little more around why URLs expire and why we need to keep refreshing the player.
kmac added a commit to kmac/mopidy-ytmusic that referenced this issue May 15, 2022
@kmac
Issue OzymandiasTheGreat#56: Refresh player and retry URL decoding on…
777b884 
… 403

Introduce a reattempt in playback._get_track on
encountering a 403 error from the verify track URL.
Refresh the youtube player and re-invoke the _get_track
method so that the URL is decoded again.
Only one reattempt is allowed.

Also introduces a wait parameter on the RepeatingTimer
now() method to block until the update method has run.

Initialize youtube player on startup (before timer)
kmac added a commit to kmac/mopidy-ytmusic that referenced this issue May 15, 2022
@kmac
Issue OzymandiasTheGreat#56: Refresh player and retry URL decoding on…
aac7c62 
… 403

Introduce a reattempt in playback._get_track on
encountering a 403 error from the verify track URL.
Refresh the youtube player and re-invoke the _get_track
method so that the URL is decoded again.
Only one reattempt is allowed.

Also introduces a wait parameter on the RepeatingTimer
now() method to block until the update method has run.

Initialize youtube player on startup (before timer)
entropia1 pushed a commit to entropia1/mopidy-ytmusic that referenced this issue Nov 11, 2023
@kmac
Issue OzymandiasTheGreat#56: Refresh player and retry URL decoding on…
ef615fe 
… 403

Introduce a reattempt in playback._get_track on
encountering a 403 error from the verify track URL.
Refresh the youtube player and re-invoke the _get_track
method so that the URL is decoded again.
Only one reattempt is allowed.

Also introduces a wait parameter on the RepeatingTimer
now() method to block until the update method has run.

Initialize youtube player on startup (before timer)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmac