Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about blocked payment method in empty cart #345

Open
m-treu opened this issue Jan 29, 2025 · 1 comment
Open

Warning about blocked payment method in empty cart #345

m-treu opened this issue Jan 29, 2025 · 1 comment

Comments

@m-treu
Copy link

m-treu commented Jan 29, 2025

Hello PAYONE-Team,

when you open the cart and it’s empty, a warning appears indicating that the payment method is blocked for the current cart. In the filterPaymentMethods method, the second condition is always triggered because an empty Cart object is passed. In this case, the price is set to 0 if no lineItem exists, which causes the condition in line 23 (TotalPriceFilter) to evaluate as true. This condition then removes the payment method.

PaymentMethod removed in PayonePayment\Components\PaymentFilter\TotalPriceFilter
Error/warning added in PayonePayment\Components\PaymentFilter\PayonePaymentMethodValidator (Line 33)

I would appreciate it if you could take a look at this and share your feedback with me.

Environment:
shopware: v6.6.8.2
payonepayment: 6.1.2

Kind regards

@m-treu m-treu changed the title Warning about blocked payment method in empty cart (Shopware) Warning about blocked payment method in empty cart Jan 29, 2025
@janteuber
Copy link
Contributor

Thank you for the notice. Our developers will look into this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants