Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail under python 3.13 #2

Closed
andreww opened this issue Oct 25, 2024 · 1 comment
Closed

Tests fail under python 3.13 #2

andreww opened this issue Oct 25, 2024 · 1 comment

Comments

@andreww
Copy link

andreww commented Oct 25, 2024

I tried running the tests as part of the JOSS review: openjournals/joss-reviews#7358. I see errors like this when trying to run the test cases under python 3.13 (i.e. the version currently installed by default by conda).

________________ ERROR collecting shipgrav/tests/test_grav_data.py _________________
ImportError while importing test module '/Users/andreww/Code/shipgrav/shipgrav/shipgrav/tests/test_grav_data.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../../miniforge3/envs/shipgrav/lib/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/__init__.py:5: in <module>
    from pkg_resources import resource_filename
E   ModuleNotFoundError: No module named 'pkg_resources'

I think this is basically the same as the error described at mu-editor/mu#2485 - I think the links in that issue describe the fixes.

@hfmark
Copy link
Collaborator

hfmark commented Oct 25, 2024

Now works on 3.13 (and still fine for 3.9, 3.10, 3.11)

@hfmark hfmark closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants