Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an ExcelException object rather than a string to represent MS Excel formula errors #1605

Draft
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

MarkBaker
Copy link
Member

@MarkBaker MarkBaker commented Aug 4, 2020

Return an ExcelException object rather than a string to represent MS Excel formula errors, so that formulae that return string values that do begin with a '#' can be distinguished from actual formula errors

This is:

- [X] a bugfix
- [X] a new feature

Checklist:

Why this change is needed?

MarkBaker added 26 commits August 4, 2020 09:47
…Excel formula errors, so that formulae that return string values that do begin with a '#' can be distinguished from actual formula errors
…ing only its problems with the unit tests... pity it doesn't recognise the validity of previous assertions in a test
@MarkBaker MarkBaker marked this pull request as draft August 7, 2020 12:02
MarkBaker added 3 commits August 7, 2020 17:20
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label Dec 25, 2020
@MarkBaker MarkBaker removed the stale label Dec 26, 2020
@stale
Copy link

stale bot commented Jun 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label Jun 26, 2021
@MarkBaker MarkBaker removed the stale label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants