+ + + + 닉네임 변경 + + + 잠깐! + 신청한 클래스가 있다면 + + 입금 확인을 위해 현재 닉네임을 유지해 주세요. + + + + + + + + + 취소 + + {user.guestNickname === value || value?.length === 0 || value?.length > 15 ? ( + {}} customStyle={disabledStyle} disabled> + 저장 + + ) : ( + + 저장 + + )} + + +
@@ -95,6 +109,12 @@ const GuestMyPage = () => { )} + + {isChangeNicknameModalOpen && ( + + + + )} > ) ); From 71028e705ff56250502d6365931fbfe9697b9f51 Mon Sep 17 00:00:00 2001 From: thisishwarang <101498590+thisishwarang@users.noreply.github.com> Date: Sun, 15 Sep 2024 23:44:05 +0900 Subject: [PATCH 2/2] =?UTF-8?q?[Fix/#287]=20=EA=B8=B0=EB=8A=A5=20QA=20(#28?= =?UTF-8?q?9)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: 기능 qa 반영 * fix: 클래스 뷰 리뷰 탭 suspense 수정 * fix: 리뷰 쓰기 버튼 클릭 시 라우팅 수정 * fix: 클래스 뷰 탭 height 수정 * fix: line-height 삭제 --- ...review_empty.png => image_review_empty.png} | Bin .../HostInfoCard/HostInfoCard.style.ts | 2 -- src/pages/class/page/Class/Class.style.ts | 2 ++ src/pages/class/page/Class/Class.tsx | 17 ++++++++--------- .../guest/components/MoimCard/MoimCard.tsx | 5 ++++- src/pages/host/components/StepTwo/StepTwo.tsx | 2 +- src/styles/theme.ts | 2 +- 7 files changed, 16 insertions(+), 14 deletions(-) rename public/image/graphics/{img_review_empty.png => image_review_empty.png} (100%) diff --git a/public/image/graphics/img_review_empty.png b/public/image/graphics/image_review_empty.png similarity index 100% rename from public/image/graphics/img_review_empty.png rename to public/image/graphics/image_review_empty.png diff --git a/src/pages/class/components/HostInfoCard/HostInfoCard.style.ts b/src/pages/class/components/HostInfoCard/HostInfoCard.style.ts index 204ab7b2..490edfb5 100644 --- a/src/pages/class/components/HostInfoCard/HostInfoCard.style.ts +++ b/src/pages/class/components/HostInfoCard/HostInfoCard.style.ts @@ -58,13 +58,11 @@ export const hostNameStyle = (theme: Theme) => css` export const hostKeywordStyle = (theme: Theme) => css` color: ${theme.color.purple2}; ${theme.font['body03-r-12']}; - line-height: 140%; `; export const hostDescriptionWrapper = (theme: Theme) => css` color: ${theme.color.midgray2}; ${theme.font['body03-r-12']}; - line-height: 140%; display: -webkit-box; -webkit-line-clamp: 2; diff --git a/src/pages/class/page/Class/Class.style.ts b/src/pages/class/page/Class/Class.style.ts index cb090830..5f2239d4 100644 --- a/src/pages/class/page/Class/Class.style.ts +++ b/src/pages/class/page/Class/Class.style.ts @@ -74,6 +74,8 @@ export const tabButtonStyle = (isSelected: boolean) => (theme: Theme) => css` export const tabSectionStyle = (theme: Theme) => css` background-color: ${theme.color.bg_white0}; + width: 100%; + min-height: 75rem; padding: 2.8rem 2rem; `; diff --git a/src/pages/class/page/Class/Class.tsx b/src/pages/class/page/Class/Class.tsx index e0f1ba78..13de6b14 100644 --- a/src/pages/class/page/Class/Class.tsx +++ b/src/pages/class/page/Class/Class.tsx @@ -1,5 +1,5 @@ import { useAtom } from 'jotai'; -import { useState } from 'react'; +import { Suspense, useState } from 'react'; import { useNavigate, useParams } from 'react-router-dom'; import { Pagination } from 'swiper/modules'; import { Swiper, SwiperSlide } from 'swiper/react'; @@ -64,9 +64,7 @@ const Class = () => { const { data: moimDescription, isLoading: isMoimDescriptionLoading } = useFetchMoimDescription( moimId ?? '' ); - const { data: moimNoticeList, isLoading: isMoimNoticeListLoading } = useFetchMoimNoticeList( - moimId ?? '' - ); + const { data: moimNoticeList } = useFetchMoimNoticeList(moimId ?? ''); if (isMoimDetailLoading || isMoimDescriptionLoading) { return ; } @@ -100,7 +98,6 @@ const Class = () => { showToast(); } }; - return ( @@ -161,14 +158,16 @@ const Class = () => { {selectTab === '클래스소개' && } {selectTab === '공지사항' && - (isMoimNoticeListLoading ? ( - - ) : (moimNoticeList || []).length === 0 ? ( + ((moimNoticeList || []).length === 0 ? ( ) : ( ))} - {selectTab === '리뷰' && } + {selectTab === '리뷰' && ( + }> + + + )} {selectTab === '공지사항' && moimDetail?.hostId === hostId && ( { const handleCardClick = () => { navigate(`/class/${moimId}`); }; + const handleWriteReviewClick = () => { + navigate(`/mypage/guest/myclass/${moimId}/review/write`); + }; return ( @@ -81,7 +84,7 @@ const MoimCard = ({ guestMyClassData }: MoimCardProps) => { ) : null} {moimSubmissionState === 'completed' && ( - + 리뷰 쓰기 )} diff --git a/src/pages/host/components/StepTwo/StepTwo.tsx b/src/pages/host/components/StepTwo/StepTwo.tsx index 9a84da7e..9c6acecd 100644 --- a/src/pages/host/components/StepTwo/StepTwo.tsx +++ b/src/pages/host/components/StepTwo/StepTwo.tsx @@ -107,7 +107,7 @@ const StepTwo = ({ onNext }: StepProps) => { onChange={(e) => handleInputChange(e, 'email')} placeholder="ex. pickple@gmail.com" isValid={isEmailValid} - errorMessage="유효한 이메일 주소를 \n입력해 주세요." + errorMessage="유효한 이메일 주소를 입력해 주세요." isCountValue={false} /> diff --git a/src/styles/theme.ts b/src/styles/theme.ts index 51152c90..042e7572 100644 --- a/src/styles/theme.ts +++ b/src/styles/theme.ts @@ -135,7 +135,7 @@ const theme = { ${PretendardFont}; font-size: 1.2rem; font-weight: 400; - line-height: normal; + line-height: 140%; letter-spacing: 0px; `, 'body04-m-12': css`