Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: crashes in chain binary #38

Open
cdstanford opened this issue Jun 29, 2023 · 4 comments
Open

Tracking issue: crashes in chain binary #38

cdstanford opened this issue Jun 29, 2023 · 4 comments
Labels
bug Something isn't working roadmap-unplanned Ideas for future work

Comments

@cdstanford
Copy link
Collaborator

cdstanford commented Jun 29, 2023

Binary chain crashes with stack overflow on tokio:

caleb@caleb-mac cargo-scan % cargo run --bin chain -- create data/packages/tokio policy.manifest
    Finished dev [unoptimized + debuginfo] target(s) in 0.38s
     Running `target/debug/chain create data/packages/tokio policy.manifest`
Creating audit chain
Loading audit package lockfile
Creating dependency graph
Making default policy for unicode-ident v1.0.4
Making default policy for proc-macro2 v1.0.46
Making default policy for quote v1.0.21
Making default policy for syn v1.0.102

thread 'main' has overflowed its stack
fatal runtime error: stack overflow
zsh: abort      cargo run --bin chain -- create data/packages/tokio policy.manifest
@cdstanford cdstanford added the bug Something isn't working label Jun 29, 2023
@cdstanford
Copy link
Collaborator Author

cdstanford commented Jun 29, 2023

There are also performance issues we should investigate later, as each line takes several seconds to run. Probably best to create a separate issue once this one resolves

@cdstanford cdstanford added the roadmap-unplanned Ideas for future work label Oct 25, 2023
@cdstanford
Copy link
Collaborator Author

generally deprecating the chain binary at the moment, so marking roadmap-unplanned

@cdstanford cdstanford changed the title Binary chain crashes with stack overflow on tokio Tracking issue: crashes in chain binary Oct 25, 2023
@cdstanford
Copy link
Collaborator Author

Cargo chain crash on serde-hex:

$ chain create serde-hex-0.1.0 okay
Creating audit chain
Loading audit package lockfile
Creating dependency graph
Making default policy for nodrop v0.1.14
Making default policy for array-init v0.0.4
Making default policy for unicode-ident v1.0.11
Making default policy for proc-macro2 v1.0.66
Making default policy for quote v1.0.33
Making default policy for syn v2.0.29
Error running command: Audit chain creation failed: Failed to read Cargo metadata from Cargo.toml file /home/d/hack/cargo-scan/.audit_crates/syn-2.0.29/Cargo.toml, Some(Version { major: 1, minor: 72, patch: 0 })

@cdstanford
Copy link
Collaborator Author

we're seeing a similar crash on serde-derive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working roadmap-unplanned Ideas for future work
Projects
None yet
Development

No branches or pull requests

2 participants